Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace usage of render with get_response #26088

Merged

Conversation

surajshetty3416
Copy link
Member

@surajshetty3416 surajshetty3416 commented Jun 17, 2021

  • Replace render imports with get_response
  • Import clear_cache from utils.py

changes required for frappe/frappe#12334

- Build frappe assets since it is used for print views
@coveralls
Copy link

coveralls commented Jun 17, 2021

Coverage Status

Coverage remained the same at 42.689% when pulling e8e4841 on surajshetty3416:refactor-website-routing into 1c1e25d on frappe:develop.

@surajshetty3416
Copy link
Member Author

surajshetty3416 commented Jun 17, 2021

All tests are passing with dependent code in Frappe.
Screenshot 2021-06-17 at 8 21 17 PM

@surajshetty3416 surajshetty3416 merged commit 6894cc2 into frappe:develop Jun 17, 2021
@surajshetty3416 surajshetty3416 deleted the refactor-website-routing branch June 17, 2021 15:13
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants